Skip to content

fix: Allow ctrl+space to work as leader key#8156

Open
razor-x wants to merge 1 commit intoanomalyco:devfrom
rxfork:fix-ctrl-space-leader
Open

fix: Allow ctrl+space to work as leader key#8156
razor-x wants to merge 1 commit intoanomalyco:devfrom
rxfork:fix-ctrl-space-leader

Conversation

@razor-x
Copy link
Copy Markdown

@razor-x razor-x commented Jan 13, 2026

What does this PR do?

Closes #3657 (which should have been re-opened)

Summary

  • Normalize ParsedKey events so ctrl+space (NUL) and ctrl+_ map to named keys in one place.
  • Add focused unit tests that fails pre-fix by asserting NUL maps to ctrl+space.

How did you verify your code works?

Tested locally and added test for key detection. Test verified failing before src changes.

@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found.

The search results show PR #8156 (the current PR) and some related keybind PRs (#8151, #5218, #6753), but none of these are duplicates addressing the same ctrl+space leader key issue. PR #8151 is about a different keybind problem (app_exit keybind), and the others are about different aspects of keybinding functionality.

@razor-x razor-x force-pushed the fix-ctrl-space-leader branch from f8e838f to 3b38ed1 Compare January 13, 2026 08:02
@razor-x razor-x marked this pull request as ready for review January 13, 2026 08:02
@thdxr thdxr force-pushed the dev branch 3 times, most recently from f1ae801 to 08fa7f7 Compare January 30, 2026 14:37
@razor-x razor-x force-pushed the fix-ctrl-space-leader branch 2 times, most recently from 65b894a to e4ebed4 Compare March 23, 2026 07:06
@razor-x razor-x force-pushed the fix-ctrl-space-leader branch from e4ebed4 to 807864d Compare April 6, 2026 22:20
@razor-x razor-x force-pushed the fix-ctrl-space-leader branch from 807864d to 36f6329 Compare April 6, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

space key in leader keybind

1 participant